-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Move ServiceBus extension to Azure SDK repo #17951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should we delete the snk file if we are not using it? |
|
My approval is based on the understanding that we're moving over existing assets; I've only reviewed the new SDK repository assets like the CI configuration and Changelog in any depth. I've taken a cursory look over the rest. Please let me know if you'd like me to give a deeper look at anything specific. |
Leaving for now as we want to use this eventually. |
sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/stylecop.json
Show resolved
Hide resolved
...crosoft.Azure.WebJobs.Extensions.ServiceBus.Tests/WebJobs.Extensions.ServiceBus.Tests.csproj
Outdated
Show resolved
Hide resolved
...crosoft.Azure.WebJobs.Extensions.ServiceBus.Tests/WebJobs.Extensions.ServiceBus.Tests.csproj
Outdated
Show resolved
Hide resolved
|
Are the "snk" files in this PR needed? Is there a reason they are not using the standard snk files from the eng folder in the repo? |
No, they aren't, but we will add new ones once we get them from the service team. The reason for not using the standard ones is that we don't want to change the full assembly name between versions. |
|
For the shipping libraries I think it is fine but for the test assemblies there is not reason to have a checked unique key. Also for the test folder I see both a sign.snk and the AzureSdkTestLibKey.snk file. I don't think there should be any reason to have either of those in the test folder. |
|
Hello @JoshLove-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Azure#17560 Moving the extensions from https://github.com/Azure/azure-functions-servicebus-extension with minimal changes necessary to compile and have tests passed. This will be helpful as a reference for future changes as we migrate to use the Track 2 library. Notable issues that should be converted to GH issues: - signing the sign.snk did not work as there was no private key, so I'm using the SDK repo snk - Azure#17958 - TestCommon package did not support net461 so I updated the RequiredTargetFrameworks for the test project to just be netcoreapp2.1 - Azure#17959
#17560
Moving the extensions from https://github.com/Azure/azure-functions-servicebus-extension with minimal changes necessary to compile and have tests passed. This will be helpful as a reference for future changes as we migrate to use the Track 2 library.
Notable issues that should be converted to GH issues: