Skip to content

Conversation

@JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Jan 13, 2021

#17560
Moving the extensions from https://github.com/Azure/azure-functions-servicebus-extension with minimal changes necessary to compile and have tests passed. This will be helpful as a reference for future changes as we migrate to use the Track 2 library.

Notable issues that should be converted to GH issues:

@pakrym
Copy link
Contributor

pakrym commented Jan 13, 2021

Should we delete the snk file if we are not using it?

@jsquire
Copy link
Member

jsquire commented Jan 13, 2021

My approval is based on the understanding that we're moving over existing assets; I've only reviewed the new SDK repository assets like the CI configuration and Changelog in any depth. I've taken a cursory look over the rest. Please let me know if you'd like me to give a deeper look at anything specific.

@JoshLove-msft
Copy link
Member Author

Should we delete the snk file if we are not using it?

Leaving for now as we want to use this eventually.

@weshaggard
Copy link
Member

Are the "snk" files in this PR needed? Is there a reason they are not using the standard snk files from the eng folder in the repo?

@JoshLove-msft
Copy link
Member Author

Are the "snk" files in this PR needed? Is there a reason they are not using the standard snk files from the eng folder in the repo?

No, they aren't, but we will add new ones once we get them from the service team. The reason for not using the standard ones is that we don't want to change the full assembly name between versions.

@weshaggard
Copy link
Member

For the shipping libraries I think it is fine but for the test assemblies there is not reason to have a checked unique key. Also for the test folder I see both a sign.snk and the AzureSdkTestLibKey.snk file. I don't think there should be any reason to have either of those in the test folder.

@ghost
Copy link

ghost commented Jan 14, 2021

Hello @JoshLove-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2e0c59c into Azure:master Jan 14, 2021
minnieliu pushed a commit to minnieliu/azure-sdk-for-net that referenced this pull request Jan 23, 2021
Azure#17560
Moving the extensions from https://github.com/Azure/azure-functions-servicebus-extension with minimal changes necessary to compile and have tests passed. This will be helpful as a reference for future changes as we migrate to use the Track 2 library.

Notable issues that should be converted to GH issues:
- signing the sign.snk did not work as there was no private key, so I'm using the SDK repo snk - Azure#17958
- TestCommon package did not support net461 so I updated the RequiredTargetFrameworks for the test project to just be netcoreapp2.1 - Azure#17959
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants