Skip to content

[Storage] Live tests - Wait for RBAC replication. #17385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Dec 7, 2020
Merged

[Storage] Live tests - Wait for RBAC replication. #17385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b21fbc
Wait for RBAC replication.
kasobol-msft Dec 7, 2020
7216dc5
add log.
kasobol-msft Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/storage/test-resources-post.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,7 @@ $content | Set-Content $TestConfigurationPath
Write-Verbose "Setting AZ_STORAGE_CONFIG_PATH environment variable used by Storage Tests"
# https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/authoring/commands.md#logging-commands
Write-Host "##vso[task.setvariable variable=AZ_STORAGE_CONFIG_PATH]$TestConfigurationPath"

# Wait until RBAC replicates. It has 5min SLA. https://github.com/Azure/azure-sdk-for-net/issues/17384 to find better solution.
Write-Verbose "Sleeping for 90 seconds to let RBAC replicate"
Start-Sleep -s 90
Copy link
Member

@benbp benbp Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to log that we're sleeping for 90 seconds too, that way someone reading the log output trying to figure out what's taking so long knows what's going on (especially if we bump the timeout).