Make DedicatedHostGroup.properties.supportAutomaticPlacement default to false #17224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dochung4
requested review from
YalinLi0312,
allenjzhang,
bquantump,
m-nash,
markcowl and
nisha-bhatia
as code owners
ghost
added
the
|
@dochung4 Could you fix the failed CI tests? |
Contributor
Author
@YalinLi0312 , can you please share the log for the failure? I am not able to find it. |
Contributor
Author
@YalinLi0312 , is there any update? |
|
@dochung4 Please:
|
Contributor
Author
|
|
/check-enforcer reset |
|
/check-enforcer override |
|
/check-enforcer reset |
YalinLi0312
approved these changes
Dec 15, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger PR: Azure/azure-rest-api-specs#11697
Dedicated host group automatic placement feature is currently in a limited public preview, available in a few regions for whitelisted subscriptions. It is planned to be GA'ed in some public regions in December. The initial plan was to default DedicatedHostGroup.properties.supportAutomaticPlacement to true, but recently we have agreed to default the value to false as we GA. Changing the default to false has already been made on the service side.
This PR updates only the description to the "supportAutomaticPlacement" property.