Azure Monitor Exporter: new test to verify correlation ids using Activity + iLogger #17189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
requested review from
cijothomas,
rajkumar-rangaraj and
reyang
as code owners
reyang
reviewed
Nov 25, 2020
.../tests/Microsoft.OpenTelemetry.Exporter.AzureMonitor.Integration.Tests/TelemetryItemTests.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 25, 2020
.../tests/Microsoft.OpenTelemetry.Exporter.AzureMonitor.Integration.Tests/TelemetryItemTests.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 25, 2020
.../tests/Microsoft.OpenTelemetry.Exporter.AzureMonitor.Integration.Tests/TelemetryItemTests.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 25, 2020
.../tests/Microsoft.OpenTelemetry.Exporter.AzureMonitor.Integration.Tests/TelemetryItemTests.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Nov 25, 2020
.../tests/Microsoft.OpenTelemetry.Exporter.AzureMonitor.Integration.Tests/TelemetryItemTests.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Dec 9, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
…vity + iLogger (Azure#17189) * new test to verify correlation ids using Activity + iLogger * dispose tracerProvider * de-dupe exporter options * cleanup * dedupe activitysourcename * additional activity test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of other PR (#17117).
This test sets up both ActivitySource and iLogger and verifies that the correlation ids are set on both.