Skip to content

Conversation

@rane-rajasi
Copy link

@rane-rajasi rane-rajasi commented Nov 24, 2020

…VMInstanceView, properties in AssessPatches API and patch settings in Windows and Linux Configuration in VMModel

PR for related swagger changes: Azure/azure-rest-api-specs#11768 and Azure/azure-rest-api-specs#12295

…VMInstanceView, properties in AssessPatches API and patch settings in Windows and Linux Configuration in VMModel
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@rane-rajasi rane-rajasi changed the title Adding tests for the changes in swagger api spec for patch status in … Adding tests for the changes in swagger api spec for patch status in VMInstanceView, properties in AssessPatches API and patch settings in Windows and Linux Configuration in VMModel Nov 30, 2020
@YalinLi0312
Copy link

@rane-rajasi Please make sure the related swagger PR gets merged, otherwise I can't start my review.

@rane-rajasi
Copy link
Author

Related swagger PR is now merged

@YalinLi0312
Copy link

YalinLi0312 commented Dec 3, 2020

@rane-rajasi I don't see updates in metadata, versions, and so on. Could you please follow the checklist below?

  • Swagger review PR(s) link in PR description, and the PR(s) is merged
  • Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
  • Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
  • Release notes in *.csproj is updated
  • If there's a API-version update, the API tags in Az.Sdk.props are updated
  • Generated code is not touched
  • Proper test coverage

@YalinLi0312
Copy link

YalinLi0312 commented Dec 30, 2020

@rane-rajasi If no updates, will close it next week. Thanks

@YalinLi0312 YalinLi0312 closed this Jan 4, 2021
@rane-rajasi rane-rajasi reopened this Jan 5, 2021
@rane-rajasi
Copy link
Author

Please follow up with Adam Sandor for updates regarding this PR. Since it is in compute-2020-12, Adam will have more details on the PR

@Sandido Sandido requested a review from JeffreyRichter January 6, 2021 16:42
@Sandido
Copy link
Contributor

Sandido commented Jan 21, 2021

Closing for now.

@Sandido Sandido closed this Jan 21, 2021
@rane-rajasi rane-rajasi reopened this Jan 26, 2021
@rane-rajasi rane-rajasi reopened this Feb 7, 2021
@rane-rajasi
Copy link
Author

@Sandido Updated the PR with latest from compute-2020-12. Please review

@markcowl markcowl closed this Feb 18, 2021
@markcowl markcowl deleted the branch Azure:compute-2020-12 February 18, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants