Make CheckpointStore source-shareable #17017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pakrym
commented
Nov 17, 2020
| /// <param name="consumerGroup">The name of the consumer group the ownership are associated with.</param> | ||
| /// <param name="ownershipCount">The amount of ownership received from the storage service.</param> | ||
| /// | ||
| partial void ListOwnershipComplete(string fullyQualifiedNamespace, string eventHubName, string consumerGroup, int ownershipCount) => |
Contributor
Author
There was a problem hiding this comment.
These methods are to isolate the logging code and the BlobsCheckpointStore to be included in project that doesn't have the BlobEventStoreEventSource
jsquire
approved these changes
Nov 17, 2020
sdk/eventhub/Azure.Messaging.EventHubs.Processor/src/Azure.Messaging.EventHubs.Processor.csproj
Outdated
Show resolved
Hide resolved
...eventhub/Azure.Messaging.EventHubs.Processor/src/Storage/BlobsCheckpointStore.Diagnostics.cs
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/CheckpointStore/BlobsCheckpointStore.cs
Outdated
Show resolved
Hide resolved
|
Hello @pakrym! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
So it can be consumed from the webjobs extension
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it can be consumed from the webjobs extension