[NetAppFiles]feat: bump to api version 2020-07-01 #16872
Conversation
audunn
requested review from
YalinLi0312,
allenjzhang,
bquantump,
m-nash,
markcowl and
nisha-bhatia
as code owners
audunn
changed the title
audunn
force-pushed
the
ANF-7403-NetAppFiles-to-API-Version-2020-07-01
branch
from
a44d1ef to
4c2a5a7
Compare
|
@audunn Please ensure this checklist has been passed: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist. For example, the Swagger is not linked here. |
added |
| /// <param name="label">Label for backup</param> | ||
| /// <param name="backupType">Type of backup adhoc or scheduled</param> | ||
| public Backup(string location, string id = default(string), string name = default(string), string type = default(string), System.DateTime? creationDate = default(System.DateTime?), string provisioningState = default(string), long? size = default(long?), string label = default(string), string backupType = default(string)) | ||
| public Backup(string location, string id = default(string), string name = default(string), string type = default(string), string backupId = default(string), System.DateTime? creationDate = default(System.DateTime?), string provisioningState = default(string), long? size = default(long?), string label = default(string), string backupType = default(string)) |
There was a problem hiding this comment.
This looks like a breaking change. Please let us know if this can be resolved. Thank you
There was a problem hiding this comment.
If you would like to get this change approved, the API review board needs to approve the Swagger that has already been merged. I am contacting Jeffrey on the API Review board to get this process started.
There was a problem hiding this comment.
Note that is a fix (bug fix) backupId property was added to backupProperties since that was missing from the spec. If unchanged this would cause issues for users using that particular feature.
I believe the spec (swagger) already reviewed and accepted, note the service is in preview status.
From the comment, it seems like service was already supporting this property and it was a miss on swagger side. And moreover its a read only property. signing off on the change from ARM side.
Co-authored-by: Audunn Baldvinsson <[email protected]>
3 participants
Bumps NetAppFiles .net SDK to api version 2020-07-01 Azure/azure-rest-api-specs#11032