Skip to content

SDK for api version 2020-07-01#16783

Merged
bquantump merged 1 commit intoAzure:network-july2020from
sachethegde:network-july2020
Nov 10, 2020
Merged

SDK for api version 2020-07-01#16783
bquantump merged 1 commit intoAzure:network-july2020from
sachethegde:network-july2020

Conversation

@sachethegde
Copy link
Copy Markdown
Contributor

@sachethegde sachethegde commented Nov 9, 2020

  • Swagger review PR(s) link in PR description, and the PR(s) is merged
    Revert attribute expressRouteGatewayBypass azure-rest-api-specs#11541
  • Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
  • Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
  • Release notes in *.csproj is updated
  • If there's a API-version update, the API tags in Az.Sdk.props are updated
  • Generated code is not touched
  • Proper test coverage

@check-enforcer
Copy link
Copy Markdown

check-enforcer bot commented Nov 9, 2020

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@sachethegde
Copy link
Copy Markdown
Contributor Author

/check-enforcer evaluate

@sachethegde
Copy link
Copy Markdown
Contributor Author

/check-enforcer override

@sachethegde
Copy link
Copy Markdown
Contributor Author

@MikhailTryakhov

@bquantump bquantump merged commit 3f97368 into Azure:network-july2020 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants