Skip to content

Add support for Redis Enterprise.#16700

Merged
bquantump merged 3 commits intoAzure:masterfrom
greenms:master
Nov 12, 2020
Merged

Add support for Redis Enterprise.#16700
bquantump merged 3 commits intoAzure:masterfrom
greenms:master

Conversation

@greenms
Copy link
Contributor

@greenms greenms commented Nov 6, 2020

@check-enforcer
Copy link

check-enforcer bot commented Nov 6, 2020

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

@greenms greenms marked this pull request as ready for review November 10, 2020 01:01
@greenms
Copy link
Contributor Author

greenms commented Nov 10, 2020

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@greenms
Copy link
Contributor Author

greenms commented Nov 11, 2020

Is anyone able to take a look? Thanks.

@bquantump
Copy link
Member

@greenms Please ensure all the items in this list are cheeked: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist

For example, there is no swagger link in here.

@greenms
Copy link
Contributor Author

greenms commented Nov 11, 2020

@bquantump I believe all of the items in the list are checked. Please let me know if you discover otherwise.

@bquantump
Copy link
Member

@greenms Is this a brand new service? That is, this is the first release of Reddis Enterprise?

@greenms
Copy link
Contributor Author

greenms commented Nov 11, 2020

@bquantump Yes, this is the first release of Redis Enterprise. Our public preview started 10/31/2020.

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

4 similar comments
@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@bquantump
Copy link
Member

@bquantump
Copy link
Member

@weshaggard @mitchdenny

https://dev.azure.com/azure-sdk/public/_build/results?buildId=615894&view=results

Why is this timing out? Can we bypass the timeout for now?

@weshaggard
Copy link
Member

/azp run net - mgmt - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member

@bquantump it doesn't look like a timeout it looks like a unique failure on when the retry. You it a limitation in how Devops cannot publish the same artifact more then once. To workaround this I've retriggered the entire pipeline. Hopefully that will get this unblocked.

@bquantump given there are still a number of new track 1 mgmt libraries coming in that need to be added to the mgmt.yml file, you could add information about how to handle then in the check-enforcer commenting. Just submit a PR to https://github.com/Azure/azure-sdk-for-net/blob/master/eng/CHECKENFORCER#L42 with some information about how to get a pipeline working for these type of changes.

@bquantump bquantump merged commit 1fda9a4 into Azure:master Nov 12, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
* Add support for Redis Enterprise.

* Add SessionRecords from successful tests.

* Add redisenterprise pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants