Add support for Redis Enterprise.#16700
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Is anyone able to take a look? Thanks. |
|
@greenms Please ensure all the items in this list are cheeked: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist For example, there is no swagger link in here. |
|
@bquantump I believe all of the items in the list are checked. Please let me know if you discover otherwise. |
|
@greenms Is this a brand new service? That is, this is the first release of Reddis Enterprise? |
|
@bquantump Yes, this is the first release of Redis Enterprise. Our public preview started 10/31/2020. |
|
No pipelines are associated with this pull request. |
4 similar comments
|
No pipelines are associated with this pull request. |
|
No pipelines are associated with this pull request. |
|
No pipelines are associated with this pull request. |
|
No pipelines are associated with this pull request. |
|
@greenms since this a new service, please add it to this file: https://github.com/Azure/azure-sdk-for-net/blob/master/eng/pipelines/mgmt.yml |
|
https://dev.azure.com/azure-sdk/public/_build/results?buildId=615894&view=results Why is this timing out? Can we bypass the timeout for now? |
|
/azp run net - mgmt - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@bquantump it doesn't look like a timeout it looks like a unique failure on when the retry. You it a limitation in how Devops cannot publish the same artifact more then once. To workaround this I've retriggered the entire pipeline. Hopefully that will get this unblocked. @bquantump given there are still a number of new track 1 mgmt libraries coming in that need to be added to the mgmt.yml file, you could add information about how to handle then in the check-enforcer commenting. Just submit a PR to https://github.com/Azure/azure-sdk-for-net/blob/master/eng/CHECKENFORCER#L42 with some information about how to get a pipeline working for these type of changes. |
* Add support for Redis Enterprise. * Add SessionRecords from successful tests. * Add redisenterprise pipeline.
Swagger PR was merged: Azure/azure-rest-api-specs#11360
Swagger: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/redisenterprise/resource-manager