AzureSecurityCenter - Update Microsoft.Security SDK generation #16580
Conversation
…f session records
eliagrady
requested review from
YalinLi0312,
allenjzhang,
bquantump,
m-nash,
markcowl and
nisha-bhatia
as code owners
eliagrady
changed the title
eliagrady
force-pushed
the
update_security_sdkGen
branch
from
fbebae8 to
aaf317c
Compare
|
@YalinLi0312 \ @allenjzhang Could you please follow the checklist below?
|
|
@allenjzhang , can you approve? |
|
@eliagrady can you link the swagger PR that this is associated with? |
There are no specific changes in the API in this PR - this PR is regen of the SDK and adding test coverage. |
|
Typically a release of new swagger goes out ahead of the SDK. The SDK is then regenerated off of that new swagger commit id (associated with the PR). It appears from the metadata file that this was the swagger PR? Azure/azure-rest-api-specs#11518 Is that correct? |
Azure/azure-rest-api-specs#10100 is more likely - I believe there were a few merges to azure-rest-api-specs without SDK respective generations - this PR is indented to downsize this growing gap. |
|
Here's a Swagger PR: Azure/azure-rest-api-specs#10418 (I've added the missing tests for this one) Can you please squash-merge-approve this? |
m-nash
left a comment
m-nash
left a comment
There was a problem hiding this comment.
Azure/azure-rest-api-specs#10100 was the one I was looking for which has the breaking change in it and the approved-breakingchange label.
|
Hi @m-nash , This SDK doesn't have api version generated, is that expected? |
…#16580) * autogenerated code using autorest * regen SDK * regen SDK metadata * fix AdaptiveApplicationControlsTests * fix AdaptiveApplicationControlsTests * modify subAssessment tests and sessionRecords * re-record compliances test sessions * re-record discovered security solutions test sessions * modify security alerts tests and sessionRecords * re-record iot security solutions device security groups test sessions * re-record iot security solutions test sessions * re-record iot security solutions analtyics test sessions * re-record iot security solutions test sessions * re-record AdvancedThreatProtection test sessions * adjust IotSecuritySolutionsAnalyticsRecommendation test * temp: exclude ExternalSecuritySolutionsTests - require re-recording of session records * add assessment tests and session records * update AzSdk.RP.props, AssemblyInfo.cs and csproj release notes * add iot sensors tests + session records * rename IoT to Iot (naming conventions) * remove redundant test * add iot defender settings tests + session records
4 participants
Regenerate SDK & fix tests.
Missing ExternalSecuritySolutionsTests sessionRecords - should not block since current ones are invalid as well.