-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update Options to hide traceparent and tracestate #16323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sdk/digitaltwins/Azure.DigitalTwins.Core/src/Customized/Models/CreateModelsOptions.cs
Outdated
Show resolved
Hide resolved
sdk/digitaltwins/Azure.DigitalTwins.Core/src/DigitalTwinsClient.cs
Outdated
Show resolved
Hide resolved
sdk/digitaltwins/Azure.DigitalTwins.Core/src/DigitalTwinsClient.cs
Outdated
Show resolved
Hide resolved
drwill-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like the regions for internal properties, but other than that, looks good.
|
If you're making the Options classes internal, do they get set as headers by the generated code? Does that conflict with https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/core/Azure.Core/src/Pipeline/Internal/RequestActivityPolicy.cs? // cc @pakrym as the expert here |
|
Yeah, that was my advice because the |
We shouldn't be passing down any values for these to the generated code, so we should be fine here |
|
FYI #16318 (comment) coming |
This change will render certain options look empty to users so we are removing them from the API signatures.
We have the option to just mark some of the options internal and do not implement any overrides in customized classes, but that will result in TraceParent and TraceState have the incorrect naming format : Tracestate, Traceparent