Skip to content

Added secure score operations#16307

Closed
giromm2ms wants to merge 5 commits intoAzure:masterfrom
giromm2ms:master
Closed

Added secure score operations#16307
giromm2ms wants to merge 5 commits intoAzure:masterfrom
giromm2ms:master

Conversation

@giromm2ms
Copy link
Copy Markdown
Contributor

@giromm2ms giromm2ms commented Oct 27, 2020

Swagger review PR(s):
Azure/azure-rest-api-specs#11133
Azure/azure-rest-api-specs#11262

V Swagger review PR(s) link in PR description, and the PR(s) is merged
Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
V Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
V Release notes in *.csproj is updated
V If there's a API-version update, the API tags in Az.Sdk.props are updated
V Generated code is not touched
V Proper test coverage

@giromm2ms
Copy link
Copy Markdown
Contributor Author

Waiting for input on ExternalSecuritySolutionsTests and AdaptiveApplicationControls_Put

@giromm2ms
Copy link
Copy Markdown
Contributor Author

@bquantump , I see you've been assigned to review this PR.
Please review since it is prerequisite for PS/CLI enhancements for secure score.

Thanks

@bquantump
Copy link
Copy Markdown
Member

@bquantump , I see you've been assigned to review this PR.
Please review since it is prerequisite for PS/CLI enhancements for secure score.

Thanks

Please ensure all the following are done (for example no swagger is linked here):

https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#appendix-a-pr-review-checklist

@bquantump
Copy link
Copy Markdown
Member

@giromm2ms are you planning updating this soon? If we do not hear anything by the end of the week, we will be closing this.

@giromm2ms
Copy link
Copy Markdown
Contributor Author

@bquantump , I intend to work on it tomorrow.
Please don't close it yet

@giromm2ms
Copy link
Copy Markdown
Contributor Author

As this one contains lots of merge content, I am closing it.
Please refer to #16985

@giromm2ms giromm2ms closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants