Feature/storage/blob permanent delete #16229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcc-msft
requested review from
KrzysztofCwalina,
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
ghost
added
the
kasobol-msft
reviewed
Nov 2, 2020
Comment on lines
+384
to
+394
| public partial class BlobDeleteOptions | ||
| { | ||
| public BlobDeleteOptions() { } | ||
| public Azure.Storage.Blobs.Models.BlobRequestConditions Conditions { get { throw null; } set { } } | ||
| public Azure.Storage.Blobs.Models.BlobDeleteType? DeleteType { get { throw null; } set { } } | ||
| public Azure.Storage.Blobs.Models.DeleteSnapshotsOption? SnapshotsOption { get { throw null; } set { } } | ||
| } | ||
| public enum BlobDeleteType | ||
| { | ||
| Permanent = 0, | ||
| } |
Contributor
There was a problem hiding this comment.
I'd rather make two options in BlobDeleteType instead of making DeleteType property optional. Otherwise why don't we use simple bool? (btw. I think BlobDeleteType has low risk of growing beyond two options, on the other hand it seems to enum on server side might be it's expected to grow)
Member
Author
There was a problem hiding this comment.
I suspect it will grow, since it is not a bool in the service.
Member
|
Can we use a string enum for |
Member
Author
Done. |
rickle-msft
reviewed
Nov 3, 2020
| public DeleteSnapshotsOption? SnapshotsOption { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Optional. Specifies options for deleting blob snapshots. |
There was a problem hiding this comment.
Copy paste error for the field description
seanmcc-msft
added a commit
that referenced
this pull request
Nov 5, 2020
This reverts commit 5f99b8c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.