ADT: Rename Model(s) to DtdlModel(s)#16226
Merged
Conversation
drwill-ms
requested review from
KrzysztofCwalina,
abhipsaMisra,
azabbasi,
barustum,
bikamani,
tg-msft,
timtay-microsoft and
vinagesh
as code owners
ghost
added
the
drwill-ms
force-pushed
the
feature/adt/drwill/dtdlModel
branch
from
3f4df60 to
60b4365
Compare
drwill-ms
commented
Oct 23, 2020
azabbasi
approved these changes
Oct 23, 2020
drwill-ms
requested review from
timtay-microsoft
and removed request for
timtay-microsoft
timtay-microsoft
approved these changes
Oct 23, 2020
|
|
||
| /// <summary> | ||
| /// The model definition. | ||
| /// The model definition that conforms to the Digital Twins Definition Language (DTDL). |
Member
There was a problem hiding this comment.
Should we call out that this is DTDL v2?
Contributor
Author
There was a problem hiding this comment.
Addressed in another PR as this one is merged.
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Azure SDK board review: In methods like createModels(IEnumerable models, ...) and in DigitalTwinsModelData.model we could be more descriptive