Skip to content

Conversation

@benbp
Copy link
Member

@benbp benbp commented Oct 23, 2020

The ${{ insert }} template syntax is used twice in one object, which produces valid yaml after render, but is interpreted as invalid yaml before rendering by some of our other validation scripts. This is a quick workaround to change the template syntax to produce the same result, but avoid breaking validation.

From the broken aggregate-reports pipeline

Verifying '/home/ben/sdk/azure-sdk-for-net/eng/pipelines/templates/jobs/archetype-sdk-tests-jobs.yml'
MethodInvocationException: /home/ben/.local/share/powershell/Modules/powershell-yaml/0.4.1/powershell-yaml.psm1:38
Line |
  38 |          $yamlStream.Load([YamlDotNet.Core.IParser] $parser)
     |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "Load" with "1" argument(s): "(Line: 93, Col: 15, Idx: 2994) - (Line: 93, Col: 28, Idx: 3007): Duplicate key"

InvalidOperation: /home/ben/sdk/azure-sdk-for-net/eng/common/scripts/Verify-Resource-Ref.ps1:12

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable compromise.

@benbp
Copy link
Member Author

benbp commented Oct 23, 2020

/azp run net - aggregate-reports

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@benbp
Copy link
Member Author

benbp commented Oct 23, 2020

/azp run net - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 23, 2020

Manually queueing the aggregate reports job: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=588540&view=results

@benbp benbp force-pushed the benbp/yaml-validation-each branch from 3db2c05 to 5a5a4e7 Compare October 23, 2020 18:45
@benbp benbp merged commit 3953475 into master Oct 23, 2020
@benbp benbp deleted the benbp/yaml-validation-each branch October 23, 2020 19:57
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants