[Storage][Webjobs] Doc strings and drop Core dependency.#16221
Merged
kasobol-msft merged 5 commits intoAzure:masterfrom Oct 23, 2020
Merged
[Storage][Webjobs] Doc strings and drop Core dependency.#16221kasobol-msft merged 5 commits intoAzure:masterfrom
kasobol-msft merged 5 commits intoAzure:masterfrom
Conversation
ghost
added
the
kasobol-msft
requested review from
amishra-dev,
amnguye,
fabiocav,
seanmcc-msft and
tg-msft
as code owners
kasobol-msft
changed the title
pakrym
reviewed
Oct 23, 2020
| </PropertyGroup> | ||
|
|
||
| <Import Condition="'$(IsClientLibrary)' == 'true' AND '$(IsMgmtClientLibrary)' != 'true'" Project="$(MSBuildThisFileDirectory)..\core\Azure.Core\src\Azure.Core.props" /> | ||
| <Import Condition="'$(IsClientLibrary)' == 'true' AND '$(IsMgmtClientLibrary)' != 'true' AND '$(IsWebjobsProject)' != 'true'" Project="$(MSBuildThisFileDirectory)..\core\Azure.Core\src\Azure.Core.props" /> |
Contributor
There was a problem hiding this comment.
Can we just move this reference to individual projects that need it?
Contributor
Author
There was a problem hiding this comment.
Looks like Azure.Storage.Common uses Core types and anything else within Storage is using that. So I moved it there.
amnguye
approved these changes
Oct 23, 2020
pakrym
approved these changes
Oct 23, 2020
Contributor
Author
|
/check-enforcer override |
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* todo docs. * blob docs strings. * queue docs. * remove explicit dependency on core from webjobs. * PR Feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: