Skip to content

[Event Hubs Client] Incorporate Feedback #16220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquire merged 1 commit into from
Oct 23, 2020
Merged

[Event Hubs Client] Incorporate Feedback #16220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/eventhub/Azure.Messaging.EventHubs.Processor/src/EventProcessorClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ public EventProcessorClient(BlobContainerClient checkpointStore,
///
/// <remarks>
/// The container associated with the <paramref name="checkpointStore" /> is expected to exist; the <see cref="EventProcessorClient" />
/// does not assume the ability to manage the storage account and is safe to run without permission to manage the storage account.
/// does not assume the ability to manage the storage account and is safe to run with only read/write permission for blobs in the container.
/// </remarks>
///
public EventProcessorClient(BlobContainerClient checkpointStore,
Expand All @@ -445,7 +445,7 @@ public EventProcessorClient(BlobContainerClient checkpointStore,
///
/// <remarks>
/// The container associated with the <paramref name="checkpointStore" /> is expected to exist; the <see cref="EventProcessorClient" />
/// does not assume the ability to manage the storage account and is safe to run without permission to manage the storage account.
/// does not assume the ability to manage the storage account and is safe to run with only read/write permission for blobs in the container.
/// </remarks>
///
public EventProcessorClient(BlobContainerClient checkpointStore,
Expand Down
2 changes: 1 addition & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs/src/EventHubConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ internal static string BuildConnectionAudience(EventHubsTransportType transportT
/// <param name="eventHubName">The name of the Event Hub being connected to.</param>
/// <param name="transportType">The type of transport being used for the connection.</param>
///
/// <returns>The <see cref="SharedAccessSignatureCredential" /> which the <paramref name="credential" /> was translated into.</returns>
/// <returns>The <see cref="SharedAccessSignatureCredential" /> which the <paramref name="credential" /> was translated into, if the parameters were populated; otherwise, <c>null</c>.</returns>
///
internal static SharedAccessSignatureCredential TranslateSharedKeyCredential(EventHubsSharedAccessKeyCredential credential,
string fullyQualifiedNamespace,
Expand Down