Search SDK: Fix data corruption when using non-nullable types in mode… #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l classes Fix for issue: Azure#1063 Added a new IContractResolver to adjust DefaultValueHandling for non-nullable properties. There is still a case where you can get JsonSerializationException (as shown in the new tests), but the data corruption issue where 0/false/etc. were converted to null has been fixed.
Contributor
|
Can one of the admins verify this patch? |
stankovski
added a commit
that referenced
this pull request
Nov 25, 2015
Search SDK: Fix data corruption when using non-nullable types in mode…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l classes
Fix for issue: #1063
Added a new IContractResolver to adjust DefaultValueHandling for non-nullable
properties. There is still a case where you can get JsonSerializationException
(as shown in the new tests), but the data corruption issue where 0/false/etc.
were converted to null has been fixed.