Skip to content

Ensure receive link is established when renewing session lock#16134

Merged
JoshLove-msft merged 1 commit intoAzure:masterfrom
JoshLove-msft:renew-session
Oct 21, 2020
Merged

Ensure receive link is established when renewing session lock#16134
JoshLove-msft merged 1 commit intoAzure:masterfrom
JoshLove-msft:renew-session

Conversation

@JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Oct 21, 2020

Fixes #16092

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a kind of issue I'd see with the stress tests I'm making? (One of them is refreshing session locks). Also, is there any way to have a test for this?

@JoshLove-msft
Copy link
Member Author

Is this a kind of issue I'd see with the stress tests I'm making? (One of them is refreshing session locks). Also, is there any way to have a test for this?

Can the stress test simulate a network fault? Otherwise it is kind of tricky to test.

@JoshLove-msft JoshLove-msft merged commit d94aefc into Azure:master Oct 21, 2020
@jsquire
Copy link
Member

jsquire commented Oct 21, 2020

Is this a kind of issue I'd see with the stress tests I'm making? (One of them is refreshing session locks). Also, is there any way to have a test for this?

Can the stress test simulate a network fault? Otherwise it is kind of tricky to test.

Not presently. Some induced failures are on the wish list, but I'd speculate that they're a ways out.

annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RenewSessionLockAsync behavior

3 participants