Fix job conditions to allow cancelling#16126
Merged
weshaggard merged 1 commit intoAzure:masterfrom Oct 20, 2020
Merged
Conversation
weshaggard
requested review from
chidozieononiwu,
danieljurek and
mitchdenny
as code owners
Member
Author
|
/azp run net - template - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chidozieononiwu
approved these changes
Oct 20, 2020
Member
Author
|
/azp run net - template - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
The conditions at the job level are inherited at each step level if the step doesn't override the condition so we need to make sure we add the "succeededOrFailed" function so that steps can be cancelled.
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
Continuation of Azure#16126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @mikeharder @chidozieononiwu