Hide ability to create a ShareLeaseClient for a Share or ShareSnapshot#16119
Merged
seanmcc-msft merged 2 commits intoAzure:masterfrom Oct 23, 2020
Merged
Conversation
seanmcc-msft
requested review from
KrzysztofCwalina,
amishra-dev,
amnguye,
kasobol-msft and
tg-msft
as code owners
ghost
added
the
Member
Author
|
/azp run net - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| - Renamed ShareClient.SetTier() -> ShareClient.SetProperties(). SetProperties() can be used to set both Share Tier and Share Quota. | ||
| - Changed ShareDeleteOptions.IncludeSnapshots -> .ShareSnapshotsDeleteOption, and added option to also delete Share Snapshots that have been leased. | ||
| - Added additional info to exception messages. | ||
| - Removed ability to create a ShareLeaseClient for a Share or Share Snapshot. Unfortunately, this feature was pulled due to a service bug, and will be re-enabled in the future. |
Contributor
There was a problem hiding this comment.
I'd word it "This feature has been rescheduled for future release"
kasobol-msft
approved these changes
Oct 23, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.