Merged
Conversation
timtay-microsoft
requested review from
abhipsaMisra,
azabbasi,
barustum,
bikamani,
drwill-ms and
vinagesh
as code owners
ghost
added
the
| string sampleFloorModelId = "dtmi:com:samples:SampleFloor;1"; | ||
| try | ||
| { | ||
| Console.WriteLine($"Deleting model Id '{sampleBuildingModelId}' if it exists."); |
Member
Author
There was a problem hiding this comment.
If the sample runs once but fails to cleanup, we need to make sure that these model Ids are available to create upon any subsequent runs
drwill-ms
reviewed
Oct 20, 2020
| Console.WriteLine($"Deleting model Id '{sampleBuildingModelId}' if it exists."); | ||
| await client.DeleteModelAsync(sampleBuildingModelId); | ||
| } | ||
| catch (Exception ex) |
Contributor
There was a problem hiding this comment.
Don't need ex if unused.
drwill-ms
reviewed
Oct 20, 2020
| // Model did not exist yet, and that's fine | ||
| } | ||
|
|
||
| try |
Contributor
There was a problem hiding this comment.
Do you think this would read better if this try/catch block was a helper method?
It seems to me it isn't central to the reading of the sample, but more about smooth operation of a sample.
drwill-ms
approved these changes
Oct 20, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.