Add support for AES encryption and key wrap algorithms#16025
Merged
heaths merged 6 commits intoAzure:masterfrom Oct 22, 2020
Merged
Add support for AES encryption and key wrap algorithms#16025heaths merged 6 commits intoAzure:masterfrom
heaths merged 6 commits intoAzure:masterfrom
Conversation
Resolves Azure#14887
heaths
commented
Oct 15, 2020
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/EncryptOptions.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Note this is only for feedback. Once we have some initial consensus I'll add unit tests, work on adding recorded tests (we have an an environment I should be able to access), and leverage what algorithms we may from track 1 if they have been reviewed. |
christothes
approved these changes
Oct 16, 2020
Member
christothes
left a comment
christothes
left a comment
There was a problem hiding this comment.
LGTM - Added some nits and minor suggestions.
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/CryptographyClient.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/CryptographyClient.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/CryptographyClient.cs
Outdated
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/src/Cryptography/LocalCryptographyClient.cs
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Oct 20, 2020
sdk/keyvault/Azure.Security.KeyVault.Keys/api/Azure.Security.KeyVault.Keys.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
schaabs
approved these changes
Oct 21, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* Add oct-HSM key type Resolves Azure#14887 * Add additional encryption algorithms to Keys Resolves Azure#14888 * Add AES-CBC and AES-GCM implementations/proxies * Add AES support to AesCryptographyProvider * Use factory methods for encrypt/decrypt options * Update public API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14887 and resolves #14888