[DataFactory]Added publicNetworkAccess property to datafactory and added logSettings property into CopyActivity #15961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge0923
Jingshu923
requested review from
YalinLi0312,
allenjzhang,
bquantump,
m-nash,
markcowl and
nisha-bhatia
as code owners
YalinLi0312
suggested changes
Oct 14, 2020
YalinLi0312
left a comment
YalinLi0312
left a comment
There was a problem hiding this comment.
LGTM.
One minor comment, you may forget to update the related tests.
Contributor
Author
|
Update a related test |
Jingshu923
changed the title
YalinLi0312
approved these changes
Oct 19, 2020
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
…ded logSettings property into CopyActivity (Azure#15961)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swagger pr:
Added publicNetworkAccess property to datafactory : add publicNetworkAccess property to datafactory azure-rest-api-specs#10956