Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Update AutoRest C# version to 1.0.0-alpha.20201012.1

@pakrym
Copy link
Contributor

pakrym commented Oct 12, 2020

This change relaxes the serialization rules for properties not-marked as nullable but received with null value.

In RELEASE mode this scenario won't throw an exception anymore making sure customers are not blocked by an exception they can't fix.

@ghost
Copy link

ghost commented Oct 12, 2020

Hello @pakrym!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tables looks good.

@azure-sdk azure-sdk force-pushed the auto-update-autorest branch from 37278d4 to f39165b Compare October 13, 2020 00:54
@azure-sdk azure-sdk force-pushed the auto-update-autorest branch from f39165b to bd59c3e Compare October 13, 2020 19:26
from: swagger-document
where: $.definitions.DeploymentOperationProperties
transform: >
$.properties.statusMessage["x-nullable"] = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @allenjzhang

This needs to be updated in the upstream swagger

@pakrym
Copy link
Contributor

pakrym commented Oct 13, 2020

Test failure is filed and seems unrelated #15936

@pakrym
Copy link
Contributor

pakrym commented Oct 13, 2020

/check-enforcer override

@pakrym pakrym merged commit 52d17f8 into Azure:master Oct 13, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants