[TA] Delete length property from library#15534
Merged
maririos merged 1 commit intoAzure:masterfrom Sep 30, 2020
Merged
Conversation
maririos
requested review from
deyaaeldeen,
iscai-msft,
kinelski and
mssfang
maririos
requested review from
KrzysztofCwalina,
annelo-msft and
tg-msft
as code owners
ghost
added
the
deyaaeldeen
reviewed
Sep 29, 2020
deyaaeldeen
reviewed
Sep 29, 2020
mssfang
reviewed
Sep 29, 2020
mssfang
approved these changes
Sep 29, 2020
deyaaeldeen
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we don't expose the encoding to the user, so the
Lengthproperty can be calculated from theTextproperty by doingText.Length. Because of that we decided to removeLengthuntil we really need it.Fixes: #15498