Skip to content

Conversation

@Jingshu923
Copy link
Contributor

@Jingshu923 Jingshu923 commented Sep 23, 2020

Update Rest Sink properties Swagger PR: Azure/azure-rest-api-specs#10815
Added support lzo in orc format: Azure/azure-rest-api-specs#10886
Added MongoDbAtlas Source Connector in DataFactory: Azure/azure-rest-api-specs#10890

@bquantump
Copy link
Member

Since the swagger PR was a breaking change, we need to bump the version for the SDK based on the new rules. @allenjzhang

@Jingshu923
Copy link
Contributor Author

@allenjzhang @bquantump Need I do some change to bump the version for the SDK based on the new rules, I don't know what it mean.

@bquantump
Copy link
Member

bquantump commented Sep 25, 2020

@allenjzhang @bquantump Need I do some change to bump the version for the SDK based on the new rules, I don't know what it mean.

Follow this:

  • Swagger review PR(s) link in PR description, and the PR(s) is merged
  • Metadata file eng/mgmt/mgmtmetadata_{RP}.txt is updated
  • Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver
  • Release notes in *.csproj is updated
  • If there's a API-version update, the API tags in Az.Sdk.props are updated
  • Generated code is not touched

@Jingshu923
Copy link
Contributor Author

@bquantump These things I have updated, could you please review it again?

@Jingshu923 Jingshu923 changed the title [DataFactory]Update Rest Sink properties [DataFactory]Update Rest Sink properties And Added support lzo in orc format, MongoDbAtlas Source Connector in DataFactory Sep 27, 2020
@bquantump
Copy link
Member

bquantump commented Sep 29, 2020

@bquantump These things I have updated, could you please review it again?

Where are the version bumps?
Versions in *.csproj and AssemblyInfo.cs are updated, and follows semver

@Jingshu923
Copy link
Contributor Author

@bquantump The versions will be updated in the PR after our sdk release, so this PR will not update version.

@bquantump bquantump merged commit 47a0c29 into Azure:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants