Skip to content

Update FromObjectAsync return type #15192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshLove-msft merged 1 commit into from
Sep 16, 2020
Merged

Update FromObjectAsync return type #15192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/core/Azure.Core.Experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release History

## 0.1.0-preview.6 (Unreleased)

### Breaking Changes
- `BinaryData`: Change return type of `FromObjectAsync` from `Task<T>` to `ValueTask<T>`

## 0.1.0-preview.5 (2020-09-03)

### Added
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/Azure.Core.Experimental/api/Azure.Core.Experimental.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ public readonly partial struct BinaryData
public static Azure.BinaryData FromBytes(byte[] data) { throw null; }
public static Azure.BinaryData FromBytes(System.ReadOnlyMemory<byte> data) { throw null; }
public static Azure.BinaryData FromBytes(System.ReadOnlySpan<byte> data) { throw null; }
public static System.Threading.Tasks.Task<Azure.BinaryData> FromObjectAsync<T>(T serializable, Azure.Core.Serialization.ObjectSerializer serializer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.Task<Azure.BinaryData> FromObjectAsync<T>(T jsonSerializable, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<Azure.BinaryData> FromObjectAsync<T>(T serializable, Azure.Core.Serialization.ObjectSerializer serializer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static System.Threading.Tasks.ValueTask<Azure.BinaryData> FromObjectAsync<T>(T jsonSerializable, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static Azure.BinaryData FromObject<T>(T serializable, Azure.Core.Serialization.ObjectSerializer serializer, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static Azure.BinaryData FromObject<T>(T jsonSerializable, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public static Azure.BinaryData FromStream(System.IO.Stream stream) { throw null; }
Expand Down
6 changes: 3 additions & 3 deletions sdk/core/Azure.Core.Experimental/src/Primitives/BinaryData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public static BinaryData FromObject<T>(
/// <param name="cancellationToken">The <see cref="CancellationToken"/> to use during serialization.</param>
///
/// <returns>A <see cref="BinaryData"/> instance.</returns>
public static async Task<BinaryData> FromObjectAsync<T>(
public static async ValueTask<BinaryData> FromObjectAsync<T>(
T jsonSerializable,
CancellationToken cancellationToken = default) =>
await FromObjectInternalAsync<T>(jsonSerializable, s_jsonSerializer, true, cancellationToken).ConfigureAwait(false);
Expand Down Expand Up @@ -266,13 +266,13 @@ public static BinaryData FromObject<T>(
///
/// <param name="cancellationToken">The <see cref="CancellationToken"/> to use during serialization.</param>
/// <returns>A <see cref="BinaryData"/> instance.</returns>
public static async Task<BinaryData> FromObjectAsync<T>(
public static async ValueTask<BinaryData> FromObjectAsync<T>(
T serializable,
ObjectSerializer serializer,
CancellationToken cancellationToken = default) =>
await FromObjectInternalAsync<T>(serializable, serializer, true, cancellationToken).ConfigureAwait(false);

private static async Task<BinaryData> FromObjectInternalAsync<T>(
private static async ValueTask<BinaryData> FromObjectInternalAsync<T>(
T data,
ObjectSerializer serializer,
bool async,
Expand Down