Clear system properties when creating a sendable message from a received message #14976
Conversation
JoshLove-msft
requested review from
KrzysztofCwalina,
MiYanni,
ShivangiReja,
jsquire and
pakrym
as code owners
ghost
added
JoshLove-msft
added
Client
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MiYanni
left a comment
MiYanni
left a comment
There was a problem hiding this comment.
Looks good. I like that the constants are all in the same place now.
|
/azp run net - servicebus - tests |
|
/azp run net - servicebus - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run net - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Is it a user property? This is a system property key, set by the broker.
There was a problem hiding this comment.
It is in the user properties bag since the user can actually set the reason/error when deadlettering.
There was a problem hiding this comment.
It's not set directly, unlike user set properties/headers. The value is passed into dead-letter method and set by the broker.
Also, it's a single usecase. Messages dead letter for other reasons and messages are neither controlled nor set by users but the broker.
There was a problem hiding this comment.
Correct, but the doc comments were intended to indicate where the property key lives. It wasn't meant to imply that a user can just change it whenever. I can clarify.
|
/azp run net - servicebus - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JoshLove-msft
force-pushed
the
amqp-received-clear
branch
from
c270747 to
c906bb6
Compare
JoshLove-msft
force-pushed
the
amqp-received-clear
branch
from
c906bb6 to
2d9b72a
Compare
3 participants
Fixes #14765
Azure.Core.Experimental was already released so this will have to wait until next release for the Core changes, but they are an implementation detail that the SB library is not depending on so it should be fine to release SB this month.