Skip to content

Properly segment StorageEndpointSuffix and CosmosEndpointSuffix #14754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christothes merged 1 commit into from
Sep 2, 2020
Merged

Properly segment StorageEndpointSuffix and CosmosEndpointSuffix #14754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/tables/Azure.Data.Tables/tests/TablesTestEnvironment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ public TablesTestEnvironment() : base("tables")
}

// Storage Tables
public const string DefaultStorageSuffix = ".table.core.windows.net";
public const string DefaultStorageSuffix = "core.windows.net";
public string PrimaryStorageAccountKey => GetRecordedVariable("TABLES_PRIMARY_STORAGE_ACCOUNT_KEY", options => options.IsSecret(SanitizedValue.Base64));
public string StorageAccountName => GetRecordedVariable("TABLES_STORAGE_ACCOUNT_NAME");
public string StorageUri => $"https://{StorageAccountName}{StorageEndpointSuffix ?? DefaultStorageSuffix}";
public string StorageUri => $"https://{StorageAccountName}.table.{StorageEndpointSuffix ?? DefaultStorageSuffix}";

// Cosmos Tables
public string CosmosEndpointSuffix => GetRecordedOptionalVariable("COSMOS_TABLES_ENDPOINT_SUFFIX") ?? ".table.cosmos.azure.com";
public string CosmosEndpointSuffix => GetRecordedOptionalVariable("COSMOS_TABLES_ENDPOINT_SUFFIX") ?? "cosmos.azure.com";
public string PrimaryCosmosAccountKey => GetRecordedVariable("TABLES_PRIMARY_COSMOS_ACCOUNT_KEY", options => options.IsSecret(SanitizedValue.Base64));
public string CosmosAccountName => GetRecordedVariable("TABLES_COSMOS_ACCOUNT_NAME");
public string CosmosUri => $"https://{CosmosAccountName}{CosmosEndpointSuffix}";
public string CosmosUri => $"https://{CosmosAccountName}.table.{CosmosEndpointSuffix}";
}
}