Conversation
chidozieononiwu
requested review from
AlexGhiondea,
AlexanderSher,
allenjzhang,
amishra-dev,
amnguye,
annelo-msft,
danieljurek,
heaths,
jsquire,
kasobol-msft,
mitchdenny,
schaabs,
seanmcc-msft,
serkantkaraca,
tg-msft and
weshaggard
as code owners
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
KV LGTM, but should we maybe take this opportunity to define an aka link so we can update it next time it changes without changing a bunch of source files (older files will be wrong still, so the aka link has a benefit for older files as well)?
What will be a good vanity name |
chidozieononiwu
force-pushed
the
FixBrokenLinksinRepo
branch
from
3bab79a to
39463e4
Compare
|
FYI @sima-zhu looks like this PR is fixing some of the broken links I pointed out to you earlier. |
| https://github.com/Azure/azure-sdk-for-net-pr/tree/feature/IoT-ADT/sdk/digitaltwins/Azure.DigitalTwins.Core/samples/DigitalTwinsClientSample/DTDL/DigitalTwins | ||
| https://github.com/Azure/azure-sdk-for-net-pr/blob/feature/IoT-ADT/sdk/iot/Azure.Iot.DigitalTwins/samples/DigitalTwinServiceClientSample/DTDL/Relationships/HospitalRelationships.json | ||
| https://www.nuget.org/packages/Azure.ResourceManager.DigitalTwins | ||
| https://contoso.azureedge.net/urlsigning/test?expires=2145916800&keyid:key1&signature=iTsrLX9rVAIJkSahBA_j5o9Azf5-j331ohxDR1Gx2js= |
There was a problem hiding this comment.
Why is this link being added to the ignore list?
There was a problem hiding this comment.
Am not sure what it does but it is not a broken link. It does link to something.
There was a problem hiding this comment.
@sima-zhu can you please investigate to see if there is something wrong with our link checker for this link?
4 participants
Fix Broken Links Identified by the link verification check