Skip to content

Conversation

@brjohnstmsft
Copy link
Member

The Azure Search REST API now supports making Search and Suggest requests
using HTTP POST instead of GET. Some customers have very large queries that
won't fit on the URL query string. POST gives them the choice to put their
queries in the request body instead.

This PR changes the behavior of the Search SDK to use POST instead of GET for
Search and Suggest calls, unless the caller sets the UseHttpGetForQueries
property on ISearchIndexClient. It also splits SearchTests and SuggestTests
into separate derived classes that exercise both POST and GET variations. This
required re-recording all the mock session records.

The Azure Search REST API now supports making Search and Suggest requests
using HTTP POST instead of GET. Some customers have very large queries that
won't fit on the URL query string. POST gives them the choice to put their
queries in the request body instead.

This PR changes the behavior of the Search SDK to use POST instead of GET for
Search and Suggest calls, unless the caller sets the UseHttpGetForQueries
property on ISearchIndexClient. It also splits SearchTests and SuggestTests
into separate derived classes that exercise both POST and GET variations. This
required re-recording all the mock session records.
@azurecla
Copy link

Hi @brjohnstmsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (brjohnst). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

ogail added a commit that referenced this pull request Aug 20, 2015
Search SDK: Add POST support to Search and Suggest
@ogail ogail merged commit d2cd2a8 into Azure:master Aug 20, 2015
@brjohnstmsft brjohnstmsft deleted the postquery-pr branch August 20, 2015 21:24
brjohnstmsft added a commit to brjohnstmsft/azure-sdk-for-net that referenced this pull request Aug 21, 2015
Used git cherry-pick to move these recent PRs from the master branch to the
AutoRest branch:

Azure#1384
Azure#1378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants