Fix #10904: Task extensions synchronously complete ValueTasks #13719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pakrym
reviewed
Jul 27, 2020
| #if DEBUG | ||
| VerifyTaskCompleted(task.IsCompleted); | ||
| #else | ||
| if (HasSynchronizationContext()) |
Contributor
There was a problem hiding this comment.
Not sure this is worth doing. Might break customers apps that worked just fine before.
Contributor
Author
There was a problem hiding this comment.
It may for some custom non-blocking sync context. In that case, they will report a bug and use Task.Run as a workaround while we fix it. However, if we don't throw in this case, the most common sync context scenario of interaction with UI will hang without any clue for the user why it has happened.
Contributor
Author
There was a problem hiding this comment.
That is of course if we have any bugs like that at all (this exception should be thrown only if we have sync code that waits on incomplete task while should only get the result of completed).
pakrym
approved these changes
Jul 27, 2020
Contributor
|
Do you think it's worth adding tests? |
pakrym
approved these changes
Jul 28, 2020
AlexanderSher
added a commit
to AlexanderSher/azure-sdk-for-net
that referenced
this pull request
Aug 18, 2020
…Tasks (Azure#13719)" This reverts commit 49bcc3e.
AlexanderSher
added a commit
that referenced
this pull request
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release builds, correctly wait for the value task synchronously if it runs without sync context or task scheduler, otherwise throw (#11855 (comment))