Review request for Microsoft.BotService to add version stable/2020-06-02 #13526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
suggested changes
Jul 20, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @stevengum , plsase
- Check in the metadata TXT file generated when you run
generate.ps1(details) - Update api tag in
AzSdk.RP.props, release notes in csproj - Update versions in csproj and
assemblyinfo.csif you are going to release
Thanks
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/Microsoft.Azure.Management.BotService
branch
from
7c4a4ae to
b02a6c1
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/Microsoft.Azure.Management.BotService
branch
from
b02a6c1 to
fa07172
Compare
Rerun multiapi
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/Microsoft.Azure.Management.BotService
branch
from
fa07172 to
efb4379
Compare
Member
|
Hi @stevengum You are free to base you work on the auto-generated branch, but unlike other SDKs, .NET SDK requires some manual work on top of generated code, like updating versions, release notes, and most importantly tests, so we cannot just simply merge from an automation branch. Please refer to https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#sdk-generation-from-updated-spec for the detailed steps. Thanks |
isra-fel
added
Mgmt
Member
|
Closing the PR for lack of activity. Feel free to reopen to continue working. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to release new BotService SDK via #12704