SDK add Quota command and models. Add Tests for Quota #13500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rahuls-microsoft
commented
Jul 16, 2020
rahuls-microsoft
commented
- SDK pickup Quota files for models and commands from - https://github.com/AzureSDKAutomation/azure-sdk-for-net/commits/sdkAutomation/Microsoft.Azure.Management.Reservations - Auto generated by SDK Team.
- Add Tests for Quota.
Reverting back to SubscriptionScopeProperties in IReservationOperations.cs, as it breaks the tests.
rahuls-microsoft
changed the title
Formatting and grouping them by succes and failure cases.
2. Formatting and grouping them by success and failure cases.
Contributor
Author
|
We are in public preview. Please expedite the SDK release. As we need to the SDK public link at - https://docs.microsoft.com/en-us/rest/api/reserved-vm-instances/quotaapi |
Contributor
Author
|
@erich-wang - Please review it. We need to release the SDK to public site, as the RP is in Public Preview. |
Contributor
Author
|
@erich-wang _ Please review the PR. We need to publish the SDK to public site as the RP is in Public Preview. |
isra-fel
suggested changes
Jul 20, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @rahuls-microsoft , the SDK should be generated by running generate.ps1 as our guideline says, and it will also update https://github.com/Azure/azure-sdk-for-net/blob/master/eng/mgmt/mgmtmetadata/reservations_resource-manager.txt . Be sure to check that in.
Thanks
erich-wang
approved these changes
Jul 20, 2020
erich-wang
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.