Skip to content

Updating list naming #12751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maririos merged 1 commit into from
Jun 16, 2020
Merged

Updating list naming #12751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/batch/Microsoft.Azure.Batch/src/Common/RetryPolicyCommon.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ internal static bool ShouldRetry(Exception exception, OperationContext operation
}
else
{
//Note that we use a blacklist here in order to have the most robust retry policy --
//Note that we use a disallow list here in order to have the most robust retry policy --
//attempting to guess all the possible exception types thrown by the network stack to craft a
//white list is error prone and so we avoid it.
if (exception is Microsoft.Rest.ValidationException)
{
//TODO: Consider blacklisting SystemException, but SystemException includes TimeoutException which it seems we probably want to retry on
//TODO: Consider adding SystemException to disallow list, but SystemException includes TimeoutException which it seems we probably want to retry on
shouldRetry = false;
}
else
Expand Down