[Azure Cognitive Search] Creating new SDK version to match new management-plane API Version 2020-03-13#12376
Closed
tjacobhi wants to merge 0 commit intoAzure:masterfrom
Closed
[Azure Cognitive Search] Creating new SDK version to match new management-plane API Version 2020-03-13#12376tjacobhi wants to merge 0 commit intoAzure:masterfrom
tjacobhi wants to merge 0 commit intoAzure:masterfrom
Conversation
tjacobhi
requested review from
arv100kri,
bleroy,
brjohnstmsft,
erich-wang and
isra-fel
as code owners
tjacobhi
requested review from
AlexGhiondea,
JoshLove-msft,
KrzysztofCwalina,
abhipsaMisra,
amishra-dev,
amnguye,
annelo-msft,
azabbasi,
barustum,
bikamani,
chidozieononiwu,
christothes,
danieljurek,
drwill-ms,
heaths,
jsquire,
kasobol-msft and
kinelski
as code owners
tjacobhi
requested review from
MiYanni,
ShivangiReja,
maririos,
mitchdenny,
pakrym,
prmathur-microsoft,
schaabs,
seanmcc-msft,
serkantkaraca,
tg-msft,
timtay-microsoft,
vinagesh and
weshaggard
as code owners
jsquire
requested changes
Jun 8, 2020
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
Please consider rebasing on master. I should not be seeing any changes to the Event Hubs data plane library included as part of this work.
Contributor
Author
|
Sorry, I rebased when I meant to merge in the recent changes to master. I will fix this quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK version to point to swagger changes from this PR - Updated default tag to latest stable version. #9085.
Due to data-plane tests being dependent on the generated management-plane code, all session records were re-recorded. This PR contains no changes to generated data-plane SDK code. There is planned work to separate the dependency between data-plane tests and management-plane generated code.