Skip to content

[FormRecognizer] Whitelist redacted query parameters for logging #12344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinelski merged 2 commits into from
May 28, 2020
Merged

[FormRecognizer] Whitelist redacted query parameters for logging #12344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92df23a
Added query
kinelski May 28, 2020
de96dbe
docs
kinelski May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/formrecognizer/Azure.AI.FormRecognizer/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

- `FormRecognizerClient` and `FormTrainingClient` support authentication with Azure Active Directory.
- Support to copy a custom model from one Form Recognizer resource to another.
- Headers that were marked as `REDACTED` in error messages and logs are now exposed by default.
- Headers and query parameters that were marked as `REDACTED` in error messages and logs are now exposed by default.

### Fixes

Expand Down
12 changes: 8 additions & 4 deletions sdk/formrecognizer/Azure.AI.FormRecognizer/src/FormRecognizerClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class FormRecognizerClientOptions : ClientOptions
public FormRecognizerClientOptions(ServiceVersion version = LatestVersion)
{
Version = version;
AddLoggedHeaders();
AddLoggedHeadersAndQueryParameters();
}

/// <summary>
Expand Down Expand Up @@ -53,17 +53,21 @@ internal static string GetVersionString(ServiceVersion version)
}

/// <summary>
/// Add headers that are considered safe for logging or including in error messages
/// by default.
/// Add headers and query parameters that are considered safe for logging or including in
/// error messages by default.
/// </summary>
private void AddLoggedHeaders()
private void AddLoggedHeadersAndQueryParameters()
{
Diagnostics.LoggedHeaderNames.Add("apim-request-id");
Diagnostics.LoggedHeaderNames.Add("Location");
Diagnostics.LoggedHeaderNames.Add("Operation-Location");
Diagnostics.LoggedHeaderNames.Add("Strict-Transport-Security");
Diagnostics.LoggedHeaderNames.Add("X-Content-Type-Options");
Diagnostics.LoggedHeaderNames.Add("x-envoy-upstream-service-time");

Diagnostics.LoggedQueryParameters.Add("includeKeys");
Diagnostics.LoggedQueryParameters.Add("includeTextDetails");
Diagnostics.LoggedQueryParameters.Add("op");
}
}
}