Split SearchServiceClient into separate index and indexer clients#12191
Merged
heaths merged 3 commits intoAzure:masterfrom May 20, 2020
Merged
Split SearchServiceClient into separate index and indexer clients#12191heaths merged 3 commits intoAzure:masterfrom
heaths merged 3 commits intoAzure:masterfrom
Conversation
heaths
requested review from
arv100kri,
bleroy,
brjohnstmsft and
tg-msft
as code owners
tg-msft
approved these changes
May 20, 2020
Member
tg-msft
left a comment
tg-msft
left a comment
There was a problem hiding this comment.
These changes look great. Thank you Heath! This and the other model renames were an absurd amount of work and I really appreciate everything you did to drive this to a much better place across languages.
sdk/search/Azure.Search.Documents/src/Indexes/SearchIndexClient.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12151