Skip to content

Update ASAL managed identity API version to 2020-05-01.#12187

Closed
niblak wants to merge 1 commit intoAzure:masterfrom
niblak:users/niblak/apiversion
Closed

Update ASAL managed identity API version to 2020-05-01.#12187
niblak wants to merge 1 commit intoAzure:masterfrom
niblak:users/niblak/apiversion

Conversation

@niblak
Copy link

@niblak niblak commented May 19, 2020

The ServiceFabric Managed Identity service no longer supports the API version in use here (2017-09-01). See their supported API versions here.

For our (internal) team, this has caused us to be unable to use the ASAL library with a ServiceFabric cluster. Upgrading the API version in this file and deploying the modified assembly resulted in successful authentication, and all tests appear to be passing.

@niblak niblak requested a review from AlexGhiondea as a code owner May 19, 2020 21:11
@jsquire jsquire requested a review from pakrym September 18, 2020 16:22
@jsquire
Copy link
Member

jsquire commented Sep 18, 2020

@pakrym - Would you be so kind as to provide feedback to @niblak and advise if you'd like to consider these changes or we should look to close out this PR?

@pakrym
Copy link
Contributor

pakrym commented Sep 18, 2020

cc @schaabs

Do we want to take this?

@pakrym
Copy link
Contributor

pakrym commented Sep 18, 2020

Fixes as part of #12160

@pakrym pakrym closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants