Merged
Conversation
…on post-pr walkthrough
Member
Does copy-item -force also create directories? |
Member
Based on a quick test it doesn't appear to so you still need to new-items to create the directories. |
Member
Author
|
@weshaggard I completed some local testing. I'm fairly confident that my approach for |
weshaggard
reviewed
May 19, 2020
weshaggard
reviewed
May 19, 2020
weshaggard
approved these changes
May 20, 2020
chidozieononiwu
approved these changes
May 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And refactor the artifact staging a bit.
@Azure/azure-sdk-eng
@weshaggard I've removed a bunch of
New-Iteminvocations in favor of aCopy-Itemwith-Forceparameter. If we know we're copying into a clean directory, do you see any downsides to this approach?Example Successful Release