Skip to content

Convert ValueTask to a Task before blocking #11855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pakrym wants to merge 1 commit into from
Closed

Convert ValueTask to a Task before blocking #11855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions sdk/core/Azure.Core/src/Shared/TaskExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,16 @@ public static T EnsureCompleted<T>(this ValueTask<T> task)
#if DEBUG
VerifyTaskCompleted(task.IsCompleted);
#endif

#pragma warning disable AZC0102 // Do not use GetAwaiter().GetResult(). Use the TaskExtensions.EnsureCompleted() extension method instead.
return task.GetAwaiter().GetResult();
if (task.IsCompleted)
{
return task.GetAwaiter().GetResult();
}
else
{
return task.AsTask().GetAwaiter().GetResult();
}
#pragma warning restore AZC0102 // Do not use GetAwaiter().GetResult(). Use the TaskExtensions.EnsureCompleted() extension method instead.
}

Expand All @@ -49,8 +57,16 @@ public static void EnsureCompleted(this ValueTask task)
#if DEBUG
VerifyTaskCompleted(task.IsCompleted);
#endif

#pragma warning disable AZC0102 // Do not use GetAwaiter().GetResult(). Use the TaskExtensions.EnsureCompleted() extension method instead.
task.GetAwaiter().GetResult();
if (task.IsCompleted)
{
task.GetAwaiter().GetResult();
}
else
{
task.AsTask().GetAwaiter().GetResult();
}
#pragma warning restore AZC0102 // Do not use GetAwaiter().GetResult(). Use the TaskExtensions.EnsureCompleted() extension method instead.
}

Expand All @@ -69,7 +85,6 @@ public static ConfiguredValueTaskAwaitable<T> EnsureCompleted<T>(this Configured

public static ConfiguredValueTaskAwaitable EnsureCompleted(this ConfiguredValueTaskAwaitable awaitable, bool async)
{

if (!async)
{
#if DEBUG
Expand Down