-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update dot net core #11741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dot net core #11741
Conversation
|
Is there an issue associated with this PR? Why are we adding 3.1 as a new baseline? We should consider moving our baseline up to 3.1 if we want a newer version otherwise we start to pay a higher cost for running multiple versions. |
Yes, there is Issue 11014. |
e4d0af1 to
d6182c0
Compare
@AlexGhiondea are you suggesting we move the supported baseline of .NET Core up to 3.1 in a few months? Based on https://dotnet.microsoft.com/platform/support/policy/dotnet-core .NET Core 2.1 is LTS under support until Aug 2021. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are updating can you also update the latest patch version of 2.1? Looks like 2.1.17 https://dotnet.microsoft.com/download/dotnet-core/2.1.
d6182c0 to
acbff83
Compare
acbff83 to
0bb2e91
Compare
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NETCore.Targets" PrivateAssets="all" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following instructions here to try and fix NuGet Error NU1605 that was occurring in Azure.Messaging.EventHubs.Processor.Samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right solution. Can you show the exact error you were hitting?
| <IsPackable>false</IsPackable> | ||
| <RequiredTargetFrameworks>netcoreapp2.1</RequiredTargetFrameworks> | ||
| <RequiredTargetFrameworks Condition="'$(OS)' == 'Windows_NT'">netcoreapp2.1;net461</RequiredTargetFrameworks> | ||
| <RequiredTargetFrameworks>netcoreapp2.1;netcoreapp3.1</RequiredTargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build must be failing because of either this change or the DotNetCoreSDKVersion change. I'd suggest trying to isolate each to see what is causing the build failures.
|
Closing this, will pick up the work later. |
Update DotNet Core SDK and Runtime to the latest version on build agents
Windows-2019
Ubuntu 18.04.4