Skip to content

Conversation

@chidozieononiwu
Copy link
Member

Update DotNet Core SDK and Runtime to the latest version on build agents
Windows-2019
Ubuntu 18.04.4

@weshaggard
Copy link
Member

Is there an issue associated with this PR? Why are we adding 3.1 as a new baseline? We should consider moving our baseline up to 3.1 if we want a newer version otherwise we start to pay a higher cost for running multiple versions.

@chidozieononiwu
Copy link
Member Author

Is there an issue associated with this PR? Why are we adding 3.1 as a new baseline? We should consider moving our baseline up to 3.1 if we want a newer version otherwise we start to pay a higher cost for running multiple versions.

Yes, there is Issue 11014.
I spoke with @AlexGhiondea he said we should run both netcoreapp2.1 and netcoreapp3.1 for a few months before finally switching to only 3.1.

@weshaggard
Copy link
Member

weshaggard commented May 4, 2020

I spoke with @AlexGhiondea he said we should run both netcoreapp2.1 and netcoreapp3.1 for a few months before finally switching to only 3.1.

@AlexGhiondea are you suggesting we move the supported baseline of .NET Core up to 3.1 in a few months? Based on https://dotnet.microsoft.com/platform/support/policy/dotnet-core .NET Core 2.1 is LTS under support until Aug 2021.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are updating can you also update the latest patch version of 2.1? Looks like 2.1.17 https://dotnet.microsoft.com/download/dotnet-core/2.1.

</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NETCore.Targets" PrivateAssets="all" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this needed for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following instructions here to try and fix NuGet Error NU1605 that was occurring in Azure.Messaging.EventHubs.Processor.Samples

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right solution. Can you show the exact error you were hitting?

<IsPackable>false</IsPackable>
<RequiredTargetFrameworks>netcoreapp2.1</RequiredTargetFrameworks>
<RequiredTargetFrameworks Condition="'$(OS)' == 'Windows_NT'">netcoreapp2.1;net461</RequiredTargetFrameworks>
<RequiredTargetFrameworks>netcoreapp2.1;netcoreapp3.1</RequiredTargetFrameworks>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build must be failing because of either this change or the DotNetCoreSDKVersion change. I'd suggest trying to isolate each to see what is causing the build failures.

@chidozieononiwu
Copy link
Member Author

Closing this, will pick up the work later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants