Implement remaining table entity operations #11715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-up-client-methods
pakrym
reviewed
Apr 30, 2020
pakrym
reviewed
Apr 30, 2020
| const string originalValue = "This is the original"; | ||
| const string updatedValue = "This is new and improved!"; | ||
| bool doCleanup = false; | ||
| TableServiceClient service = CreateTableServiceClient(); |
Contributor
There was a problem hiding this comment.
If all tests would need a table we might think about having a SetUp and TearDown methods that would manage that.
Member
Author
There was a problem hiding this comment.
I considered that for the whole class, but doing it per test might be better, as you suggested.
Member
Author
There was a problem hiding this comment.
I'm going to punt this to a future PR
pakrym
reviewed
Apr 30, 2020
pakrym
reviewed
Apr 30, 2020
| /// <summary> The row key continuation token for an Entity request. </summary> | ||
| public string NextRowKey { get; set; } | ||
| /// <summary> The If-Match header value for an Entity request. </summary> | ||
| public string ETag { get; set; } |
Member
Author
There was a problem hiding this comment.
Tables uses weak etags, which the ETag type doesn't allow:
Contributor
There was a problem hiding this comment.
Time to implement #9501 :)
I'm fine if we do it as a followup
pakrym
reviewed
Apr 30, 2020
pakrym
reviewed
May 1, 2020
pakrym
approved these changes
May 1, 2020
…-up-client-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus of these changes is to implement the remaining basic table entity operations and to support optimistic concurrency.