Skip to content

Performed Code Cleanup#11630

Closed
tstepanski wants to merge 82 commits intoAzure:masterfrom
tstepanski:master
Closed

Performed Code Cleanup#11630
tstepanski wants to merge 82 commits intoAzure:masterfrom
tstepanski:master

Conversation

@tstepanski
Copy link

  • Removed redundant code
  • Standardized naming and style
  • Fixed comments
  • Fixed warnings

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@jsquire jsquire added Client This issue is related to a non-management package Service Attention Workflow: This issue is responsible by Azure service team. Service Bus labels Apr 28, 2020
@jsquire
Copy link
Member

jsquire commented Apr 28, 2020

As the owners of this version of the client library, @nemakam, @shankarsama and team would be the authoritative voice for feedback here.

@AlexGhiondea AlexGhiondea assigned axisc and unassigned nemakam Aug 24, 2020
@jsquire
Copy link
Member

jsquire commented Sep 18, 2020

@axisc and @shankarsama - Would you please be so kind as to provide feedback to @tstepanski and advise if these changes are something that you'd like to consider or if we should look to close out the PR?

@jsquire
Copy link
Member

jsquire commented Sep 25, 2020

Hi @tstepanski. Thank you for your contribution, and I'm sorry that you haven't received any feedback. Unfortunately, it does not look as if the Service Bus team would like to consider these changes at this point in time. I'm going to close this out, since there hasn't been any recent activity or engagement. Please feel free to reopen if you'd like to continue working on these changes.

@jsquire jsquire closed this Sep 25, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this pull request Nov 19, 2020
set readonly property of contentStorageAccount to false (Azure#11630)

Co-authored-by: Zhejun Zhao <t-zhzhao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue is related to a non-management package Service Attention Workflow: This issue is responsible by Azure service team. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants