[Service Bus] Improve errors and update API docs as per the feedback from UX study#11592
Merged
ShivangiReja merged 3 commits intoAzure:masterfrom Apr 27, 2020
Merged
Conversation
Member
ShivangiReja
commented
Apr 25, 2020
ShivangiReja
commented
- Improve error message when user attempts to settle a peeked message.
- Update ServiceBusSender docs by making it clear that it can be used for session entities.
- Update Processor docs by including that this is used for receiving messages, not sending messages.
- Include default ReceiveMode in more places in documentation.
- Add ClientBuilderExtensions to be used for dependency injection.
ShivangiReja
requested review from
JoshLove-msft,
jsquire and
nemakam
as code owners
ShivangiReja
added
Service Bus
Client
sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClient.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClient.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClient.cs
Outdated
Show resolved
Hide resolved
| /// </summary> | ||
| private void ThrowIfLockTokenIsEmpty(string lockToken) | ||
| { | ||
| if (Guid.Parse(lockToken) == Guid.Empty) |
...servicebus/Azure.Messaging.ServiceBus/src/Compatibility/ServiceBusClientBuilderExtensions.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Client/ServiceBusClient.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Processor/ServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Apr 27, 2020
This was referenced Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.