Sender updates

[JoshLove-msft]

• Add ServiceBusSenderOptions
• Rename SendBatchAsync -> SendAsync

[JoshLove-msft]

/azp run net - servicebus - tests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ShivangiReja]

I think we shouldn't call ValidateEntityName method for queueOrTopicName and ViaQueueOrTopicName both. Think about if user passes EntityPath with connection string, then one of the above method will fail because we check in ValidateEntityName method that if the entity path specified in both(Connection.EntityPath and entityName) with different value then it will throw an exception.

if (!string.IsNullOrEmpty(Connection.EntityPath) && !string.Equals(entityName, Connection.EntityPath, StringComparison.InvariantCultureIgnoreCase))
{
      throw new ArgumentException(Resources.OnlyOneEntityNameMayBeSpecified);
}

[JoshLove-msft]

Yeah, if they pass an entity name in the connection string that means they won't be able to use SendVia, since they are restricted to that one entity. So in this case we would want to throw an exception.

[ShivangiReja]

Did you forget to update this?

[JoshLove-msft]

Updated!

[ShivangiReja]

Nice!!

[ShivangiReja]

Can we add this Messages can be added to the batch using the <see cref="TryAdd"/> method on the batch for CreateBatchAsync docs as well?

[ShivangiReja]

nit: ServiceBusClientOptions -> ServiceBusSenderOptions and ServiceBusClient -> ServiceBusSender

[ShivangiReja]

Can we update SendBatchAsync -> SendAsync in the Sending messages section and in the description of Sending and receiving batch of messages?