Skip to content

Undo excluding some mgmt plane tests projects#11561

Merged
erich-wang merged 1 commit intoAzure:masterfrom
isra-fel:unblock-test-project
Apr 24, 2020
Merged

Undo excluding some mgmt plane tests projects#11561
erich-wang merged 1 commit intoAzure:masterfrom
isra-fel:unblock-test-project

Conversation

@isra-fel
Copy link
Copy Markdown
Member

@isra-fel isra-fel commented Apr 24, 2020

Description

Some test projects of management plane SDKs were excluded for they failed to build/run after the repo restructure.
I've tested a few of them and can confirm these are fine now.

Fixes #6572, Fixes #6571, Fixes #6570


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • Title of the pull request is clear and informative.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@isra-fel isra-fel requested a review from erich-wang as a code owner April 24, 2020 08:59
@isra-fel isra-fel added the Mgmt-EngSys Engineering System (Management Plane Specific) label Apr 24, 2020
@erich-wang erich-wang merged commit 9d71488 into Azure:master Apr 24, 2020
@isra-fel isra-fel deleted the unblock-test-project branch April 26, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt-EngSys Engineering System (Management Plane Specific)

Projects

None yet

2 participants