Skip to content

Regenerate CosmosDB SDK#11542

Merged
weshaggard merged 4 commits intoAzure:masterfrom
soeom:cosmosdbacctget
Apr 30, 2020
Merged

Regenerate CosmosDB SDK#11542
weshaggard merged 4 commits intoAzure:masterfrom
soeom:cosmosdbacctget

Conversation

@soeom
Copy link
Contributor

@soeom soeom commented Apr 23, 2020 •
edited
Loading

Regenerated CosmosDB SDK

@MehaKaushik
Copy link
Contributor

MehaKaushik commented Apr 23, 2020

Add release notes in sdk/cosmosdb/Microsoft.Azure.Management.CosmosDB/src/Microsoft.Azure.Management.CosmosDB.csproj

Update the release version like here e807364

@soeom
Copy link
Contributor Author

soeom commented Apr 24, 2020

@MehaKaushik I made changes following your comment.

@MehaKaushik
Copy link
Contributor

MehaKaushik commented Apr 25, 2020

Need to change the assembly version in here as well sdk/cosmos-db/Microsoft.Azure.Management.CosmosDB/src/Properties/AssemblyInfo.cs

@soeom
Copy link
Contributor Author

soeom commented Apr 25, 2020

@isra-fel @erich-wang Please help merge the PR.

@isra-fel isra-fel self-assigned this Apr 26, 2020
@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-review labels Apr 26, 2020
isra-fel
isra-fel approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel closed this Apr 27, 2020
@isra-fel isra-fel reopened this Apr 27, 2020
@isra-fel
Copy link
Member

isra-fel commented Apr 27, 2020

/azp run net - mgmt - ci

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 27, 2020

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@soeom
Copy link
Contributor Author

soeom commented Apr 27, 2020

@isra-fel Please help run CI again

@isra-fel
Copy link
Member

isra-fel commented Apr 28, 2020

/azp run net - mgmt - ci

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 28, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Apr 28, 2020

@dingmeng-xue could you help force merge this PR? The failed CI "net - core - ci" is for Azure.Core only. It should not block management plane PR. Thanks

@soeom
Copy link
Contributor Author

soeom commented Apr 28, 2020

@dingmeng-xue Please help merge the PR

@dingmeng-xue
Copy link
Member

dingmeng-xue commented Apr 29, 2020

@dingmeng-xue could you help force merge this PR? The failed CI "net - core - ci" is for Azure.Core only. It should not block management plane PR. Thanks
I'm not managing this repo and don't have permission. @allenjzhang , do you have permission?

@soeom
Copy link
Contributor Author

soeom commented Apr 29, 2020

@allenjzhang Can you please help merge the PR?

@isra-fel
Copy link
Member

isra-fel commented Apr 30, 2020

Add @kurtzeborn @weshaggard for help force merge.
I've already excluded mgmt plane paths from net - core - ci in #11609 but this was created before it.

Thanks

@weshaggard weshaggard merged commit 291c842 into Azure:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

+1 more reviewer

@MehaKaushik MehaKaushik MehaKaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@isra-fel isra-fel

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@soeom @MehaKaushik @isra-fel @dingmeng-xue @weshaggard