De/serialize pipe-delimited array of RegexFlags #11461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
reviewed
Apr 20, 2020
sdk/search/Azure.Search.Documents/src/Utilities/SearchExtensions.cs
Outdated
Show resolved
Hide resolved
pakrym
approved these changes
Apr 21, 2020
Member
Author
|
Since the API design was already made and approved for other languages, this is mostly a change in how we de/serialize so I'm satisfied with @pakrym's approval. I confirmed it was over the whole PR. |
tg-msft
reviewed
Apr 22, 2020
sdk/search/Azure.Search.Documents/api/Azure.Search.Documents.netstandard2.0.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10748